Tokens plugins now support a remote name #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorsher
requested review from
awrichar,
nguyer,
nickgaski and
peterbroadhurst
as code owners
shorsher
force-pushed
the
remote-name-tokens
branch
from
2d9b435 to
3b47d54
Compare
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 298 298
Lines 19563 19600 +37
=======================================
+ Hits 19557 19594 +37
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
shorsher
force-pushed
the
remote-name-tokens
branch
from
3b47d54 to
c2f0bb7
Compare
awrichar
reviewed
Jul 14, 2022
awrichar
reviewed
Jul 14, 2022
awrichar
reviewed
Jul 14, 2022
awrichar
reviewed
Jul 14, 2022
Member
Author
|
Seems I accidentally pulled in some changes from #896, gonna fix them now. |
shorsher
force-pushed
the
remote-name-tokens
branch
from
c2f0bb7 to
b3ec5ba
Compare
awrichar
approved these changes
Jul 15, 2022
Contributor
awrichar
left a comment
awrichar
left a comment
There was a problem hiding this comment.
Looks good. We should probably add an E2E test.
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
- introduce a new `remotename` key for tokens plugins - `remotename` must be unique The definitions package now utilizes the `remotename` of tokens plugins. `defsender` will replace the local token plugin name with the remote name before sending the definition. The `defhandler` will then replace the `remotename` with the local name after receiving a broadcast. Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
shorsher
force-pushed
the
remote-name-tokens
branch
from
371c602 to
17dfa78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remotenameconfig key for tokens pluginsremotenamemust be uniqueremotenamewill default to the pluginnameremotenameshould never be stored in the local database.The definitions package now utilizes the
remotenameof tokens plugins.defsenderwill replace the local token plugin name with the remote name before broadcasting the definition. Thedefhandlerwill then replace theremotenamewith the local name after receiving a broadcast.