feat: add clarifying questions to pptx, pdf, xlsx skills#110
Merged
simongdavies merged 2 commits intohyperlight-dev:mainfrom May 7, 2026
Merged
Conversation
Each skill now has a structured 'Clarifying Questions' section that tells the LLM exactly what to ask when details are missing: - pptx-expert: topic, audience, slide count, purpose, theme, charts - pdf-expert: document type, topic, audience, sections, page format - xlsx-expert: purpose, data structure, data source, charts, formulas Questions are grouped into three tiers: 1. Always needed (ask if missing) 2. Ask if relevant to the request 3. Never ask (use sensible defaults) The LLM is instructed to group questions into ONE ask_user call, skip anything already specified, and offer defaults the user can accept with 'yes'. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a standardized “Clarifying Questions” section to the PPTX/PDF/XLSX skills to drive consistent requirement gathering before file generation, and updates each skill’s setup sequence to explicitly start with clarification via ask_user.
Changes:
- Introduce a structured “Clarifying Questions” section with Always needed / Ask if relevant / Never ask tiers.
- Update setup sequences to begin with a “Clarify requirements” step referencing the new section.
- Provide suggested defaults users can accept in a single consolidated
ask_userinteraction.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| skills/xlsx-expert/SKILL.md | Adds clarifying-question tiers and updates setup sequence to start with requirements clarification. |
| skills/pptx-expert/SKILL.md | Adds clarifying-question tiers (topic/audience/slide count/purpose/etc.) and updates setup sequence accordingly. |
| skills/pdf-expert/SKILL.md | Adds clarifying-question tiers (doc type/sections/page format/etc.) and updates setup sequence accordingly. |
…sset handling All 3 skills mentioned URLs/images in clarifying questions but the setup sequence only applies file-builder (fs-write), leaving the LLM unable to actually fetch remote content. - xlsx: data source URL now notes to apply web-research profile - pptx: images changed from URLs to local paths, with web-research guidance if remote URLs are needed - pdf: branding logo changed from URL to local path/bytes, with web-research guidance if remote URLs are needed Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each skill now has a structured 'Clarifying Questions' section that tells the LLM exactly what to ask when details are missing:
Questions are grouped into three tiers:
The LLM is instructed to group questions into ONE ask_user call, skip anything already specified, and offer defaults the user can accept with 'yes'.