fix: HybridFs subclass, Prettier template literal fixes, path normali…

[simongdavies]

This pull request refactors and improves the src/agent/index.ts codebase, focusing on simplifying string formatting (moving from template literals to string concatenation), enhancing the construction of the bash runner handler, and improving the hybrid filesystem adapter logic. The changes aim to make the code more robust, maintainable, and less error-prone, especially in areas involving code generation and file system operations.

Key changes include:

String Formatting and Logging Consistency

• Replaced most template literals with string concatenation for log messages and command outputs throughout src/agent/index.ts, improving compatibility and reducing parsing errors during code generation.

Bash Runner Handler and Filesystem Adapter Refactor

• Refactored the construction of the hybrid hostFs filesystem adapter to use a class-based approach (HybridFs extends InMemoryFs) with string concatenation, improving clarity and maintainability. Added a normPath helper to sanitize paths before delegating to plugins.
• Reworked the generation of the bash runner handler code to use explicit string concatenation, reducing the risk of issues with nested template literals and making the generated code easier to reason about.

Bash and Command Handler Improvements

• Improved the logic for determining and displaying available commands, including better handling of the curl command and clearer help output.
• Enhanced the construction of bash handler options using string concatenation for consistency and maintainability.

Minor Functional Improvements

• Updated the curl command to prepend https:// only if the URL does not already contain a protocol, making it more robust.
• Improved warning handling in the native DTS generator to silently skip modules that only register globals.

These changes collectively improve the maintainability and robustness of the code, especially in areas where code is dynamically generated or where string formatting is critical for correctness.

[Copilot]

Pull request overview

This PR integrates a sandboxed Bash execution path into HyperAgent (via the new execute_bash tool and a dedicated bash sandbox), along with associated build/lockfile updates and some formatting-oriented refactors to avoid Prettier/template-literal parsing issues.

Changes:

• Refactors bash runner handler generation (HybridFs adapter + handler code assembly) and replaces some nested template literals with string concatenation in src/agent/index.ts.
• Adjusts native .d.ts generation script behavior for modules without #[rquickjs::function].
• Updates dependency lockfiles (npm + Rust guest).

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/code-validator/guest/Cargo.lock	Rust dependency lockfile drift (tokio patch version change).
src/agent/index.ts	Bash sandbox/tool wiring plus HybridFs adapter refactor and string-concat formatting changes.
scripts/generate-native-dts.ts	Changes behavior when no Rust-exported functions are detected (now skips silently).
package-lock.json	NPM dependency resolution updates (including several version downgrades and an altered @types/node entry).

Comments suppressed due to low confidence (2)

src/agent/index.ts:2316

• HybridFs.readdir assumes fsRead.listDir returns an object with an entries array, but the fs-read plugin returns either a DirEntry[] array or { error }. This will throw at runtime (r.entries is undefined) and break ls/find/tree when fs-read is enabled. Update this branch to handle the actual return shape (e.g. if Array.isArray(r) map name, otherwise throw/fallback on r.error).

      "  async readdir(path) {",
      "    try { const r = fsRead.listDir(normPath(path)); if (r.error) throw new Error(r.error); return r.entries.map(e => e.name); }",
      "    catch { return super.readdir(path); }",

src/agent/index.ts:2340

• HybridFs.mkdir calls fsWrite.mkdir() but ignores its { ok, error } return value. Since fs-write reports failures via error (it generally does not throw), bash mkdir can report success even though the directory was rejected/failed to create. Capture the return value and throw/fallback when error is set (similar to writeFile/appendFile).

      "  async mkdir(path, opts) {",
      "    try { fsWrite.mkdir(normPath(path)); }",
      "    catch { await super.mkdir(path, opts); }",
      "  }",

[Copilot]

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.