Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes the crates.io publish --dry-run step from the release workflow because it fails under cargo-overlay-registry when downstream crates’ build scripts invoke cargo metadata and attempt to resolve crates that were packaged but not actually published into the overlay.
Changes:
- Deleted the “Publish dry-run” step from the release workflow to avoid the overlay-registry resolution failure.
- Leaves the real publish step intact so release branches can still publish sequentially to crates.io.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dblnz
approved these changes
Apr 8, 2026
danbugs
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the publihh dry-run step fails because hyperlight-wasm's build script spawns cargo metadata, which tries to download hyperlight-wasm-runtime and hyperlight-wasm-macro from the registry. With --dry-run, crates are packaged but never actually published to the overlay's local layer, so the build script can't resolve them. The real publish step that follows doesn't have this problem since crates are uploaded sequentially and available on crates.io by the time downstream crates need them.
fixes the release failure at https://github.com/hyperlight-dev/hyperlight-wasm/actions/runs/24108356441
Will cherry-pick into
release/v0.14.0branch after and rerun release