Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

wasmparser 0.243.0 adds FuncExact variant to ExternalKind and TypeRef enums for the custom descriptors feature, causing exhaustive match failures.

Changes

  • Added panic handlers for ExternalKind::FuncExact and TypeRef::FuncExact in src/hyperlight_component_util/src/elaborate.rs
  • Follows existing pattern for unsupported features (e.g., Tag)
ExternalKind::FuncExact => panic!("core type exact functions are not supported"),
// ...
TypeRef::FuncExact(_) => panic!("core type exact functions are not supported"),

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits December 3, 2025 21:17
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 3, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com//advisories
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update wasmparser from 0.242.0 to 0.243.0 Handle FuncExact variant added in wasmparser 0.243.0 Dec 3, 2025
Copilot AI requested a review from jsturtevant December 3, 2025 21:29
@jsturtevant jsturtevant marked this pull request as ready for review December 3, 2025 22:11
@jsturtevant
Copy link
Contributor

jsturtevant commented Dec 3, 2025

note this is going into the dependbot pr not main

@jsturtevant jsturtevant merged commit 422b883 into dependabot/cargo/wasmparser-0.243.0 Dec 3, 2025
1 check passed
@jsturtevant jsturtevant deleted the copilot/sub-pr-1069 branch December 3, 2025 22:23
jsturtevant added a commit that referenced this pull request Dec 3, 2025
* Initial plan

* Handle FuncExact variant in wasmparser 0.243.0

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

* Improve error message consistency for FuncExact handlers

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

* Fix wasmparser 0.243.0 compatibility

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
jsturtevant added a commit that referenced this pull request Dec 4, 2025
* Bump wasmparser from 0.242.0 to 0.243.0

Bumps [wasmparser](https://github.com/bytecodealliance/wasm-tools) from 0.242.0 to 0.243.0.
- [Release notes](https://github.com/bytecodealliance/wasm-tools/releases)
- [Commits](https://github.com/bytecodealliance/wasm-tools/commits)

---
updated-dependencies:
- dependency-name: wasmparser
  dependency-version: 0.243.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Handle FuncExact variant added in wasmparser 0.243.0 (#1071)

* Initial plan

* Handle FuncExact variant in wasmparser 0.243.0

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

* Improve error message consistency for FuncExact handlers

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

* Fix wasmparser 0.243.0 compatibility

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
vshailesh pushed a commit to vshailesh/hyperlight that referenced this pull request Dec 7, 2025
* Bump wasmparser from 0.242.0 to 0.243.0

Bumps [wasmparser](https://github.com/bytecodealliance/wasm-tools) from 0.242.0 to 0.243.0.
- [Release notes](https://github.com/bytecodealliance/wasm-tools/releases)
- [Commits](https://github.com/bytecodealliance/wasm-tools/commits)

---
updated-dependencies:
- dependency-name: wasmparser
  dependency-version: 0.243.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Handle FuncExact variant added in wasmparser 0.243.0 (hyperlight-dev#1071)

* Initial plan

* Handle FuncExact variant in wasmparser 0.243.0

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

* Improve error message consistency for FuncExact handlers

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

* Fix wasmparser 0.243.0 compatibility

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants