Enable 32-bit x86 guest support #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move hyperlight-guest-tracing dependency to target-specific section for x86_64 architecture only. This allows i686 and other architectures to build without x86_64-specific tracing functionality. Signed-off-by: danbugs <danilochiarlone@gmail.com>
Add CI check to ensure hyperlight-guest library builds for 32-bit x86 architecture (i686-unknown-linux-gnu) to maintain compatibility with Nanvix's custom 32-bit x86 target. Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
requested review from
dblnz,
devigned,
ludfjig,
marosset and
syntactically
as code owners
danbugs
added
the
kind/refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gate hyperlight-guest-tracing to x86_64 since it uses inline assembly that doesn't work on 32-bit. Add compile_error when trace_guest is enabled on non-x86_64 targets. Add CI check to verify hyperlight-guest builds for i686-unknown-linux-gnu.