Skip to content

Fix clippy #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simongdavies merged 2 commits into from
Dec 10, 2025
Merged

Fix clippy #1096

simongdavies merged 2 commits into from
Dec 10, 2025

Conversation

@simongdavies
Copy link
Contributor

@simongdavies simongdavies commented Dec 9, 2025

Clippy fixes

  • Removed the #[allow(clippy::large_enum_variant)] attribute from the ExeInfo enum in src/hyperlight_host/src/mem/exe.rs, as it is no longer necessary.

  • Simplified a closure in src/hyperlight_guest_bin/build.rs by removing redundant parentheses in the and_then call.

@simongdavies simongdavies added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Dec 9, 2025
@simongdavies simongdavies requested a review from danbugs as a code owner December 9, 2025 22:00
@simongdavies simongdavies added the Guest-COW PRs that form part of the Guest-COW change label Dec 9, 2025
@simongdavies simongdavies mentioned this pull request Dec 9, 2025
Draft
7 tasks
@syntactically @simongdavies
Fix Rust 0.90 Clippy warnings
fff27a6 
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
@syntactically @simongdavies
Remove clippy ignore that is not required now that PE files are gone
90003be 
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
@simongdavies simongdavies merged commit 90003be into hyperlight-dev:main Dec 10, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jprendes jprendes jprendes approved these changes

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@ludfjig ludfjig Awaiting requested review from ludfjig ludfjig is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

Assignees

No one assigned

Labels

Guest-COW PRs that form part of the Guest-COW change kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simongdavies @jprendes @syntactically