Update snapshots #1098
Merged
Update snapshots #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
added
the
kind/enhancement
simongdavies
requested review from
dblnz,
devigned,
jprendes,
marosset and
syntactically
as code owners
7 tasks
simongdavies
force-pushed
the
update-snapshots
branch
from
44522dc to
1d2b773
Compare
This moves `mem::shared_mem_snapshot::SharedMemorySNapshot` into `sandbox::snapshot::Snapshot`, because that structure has always contained more than /just/ a snapshot of a shared memory. It also removes the Arc reference counting wrapper from the new structure, and shifts the Arc wrapper into `sandbox::initialized_multi_use::MultiUseSandbox`, which is where it was actually needed. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Previously, snapshots were compared for equality by checking if they were literally the same object in memory. This replaces that comparison with a deterministic hash of the contents of the sandbox, which can be persisted to and reloaded from disk. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Make asserts errors and poision sandbox Fix hasher inputs Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
update-snapshots
branch
from
f2bfdf0 to
b7c64cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes to snapshots:
It moves
mem::shared_mem_snapshot::SharedMemorySNapshotintosandbox::snapshot::Snapshot, because that structure has always contained more than just a snapshot of a shared memory. It also removes the Arc reference counting wrapper from the new structure, and shifts the Arc wrapper intosandbox::initialized_multi_use::MultiUseSandbox, which is where it was actually needed.Previously, snapshots were compared for equality by checking if they were literally the same object in memory. This replaces that comparison with a deterministic hash of the contents of the sandbox, which can be persisted to and reloaded from disk.