-
Notifications
You must be signed in to change notification settings - Fork 157
Unignore some ignored test #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ecb179f to
d376728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies the test infrastructure by unignoring and refactoring several tests that no longer need to be run in isolation. The tests are updated to be more robust against concurrent execution and race conditions.
Changes:
- Unignored and simplified four tests:
test_trace_trace,create_200_sandboxes(reduced from 1000),test_drop, andexecute_on_heap - Improved test implementations to handle concurrent execution better by using unique sizes, exact mapping checks, and clearer assertions
- Removed unused
build_metadata_testingmodule fromlog_values.rs
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/rust_guests/simpleguest/src/main.rs | Updated return value for execute_on_heap to match new test expectations |
| src/hyperlight_host/tests/integration_test.rs | Removed #[ignore] attribute and improved assertions for execute_on_heap test |
| src/hyperlight_host/src/testing/log_values.rs | Removed unused build_metadata_testing module |
| src/hyperlight_host/src/sandbox/uninitialized.rs | Removed #[ignore] and refactored test_trace_trace with cleaner helper functions and better documentation |
| src/hyperlight_host/src/sandbox/initialized_multi_use.rs | Removed #[ignore] and reduced test from 1000 to 200 sandboxes with clearer variable naming |
| src/hyperlight_host/src/mem/shared_mem.rs | Removed #[ignore] and improved test_drop to use exact mapping checks with unique size to avoid race conditions |
| Justfile | Removed explicit runs of newly unignored tests from test-isolated, updated comment for execute_on_heap test |
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
…gger) Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Simplifies our
just-file slightly by rewriting and unignoring tests that no longer needs to be ran separately. Reviewing commit-by-commit is probably easiest. Will follow up with another PR that cleans up ourjust-file to avoid running duplicate tests, which wastes a lot of time in CI currently