Skip to content

ci: add nanvix-unstable compile checks to CI and Justfile#1294

Merged
danbugs merged 1 commit intohyperlight-dev:mainfrom
nanvix:nanvix/ci-nanvix-unstable
Mar 9, 2026
Merged

ci: add nanvix-unstable compile checks to CI and Justfile#1294
danbugs merged 1 commit intohyperlight-dev:mainfrom
nanvix:nanvix/ci-nanvix-unstable

Conversation

@danbugs
Copy link
Contributor

@danbugs danbugs commented Mar 9, 2026

Summary

Adds compile-time CI coverage for the nanvix-unstable feature flag introduced in #1291 to catch regressions on the non-CoW code path.

Only compile checks are added — not test runs — because the standard Hyperlight test guests require CoW paging, which is disabled under nanvix-unstable.

Changes

  • Justfile check: verify nanvix-unstable and nanvix-unstable,executable_heap compile on the host
  • Justfile check-i686: verify hyperlight-common builds for i686 with nanvix-unstable enabled

The check recipe is already invoked by both test-like-ci and code-checks-like-ci, so these checks run automatically in CI without needing a new workflow step.

Add CI coverage for the nanvix-unstable feature flag to catch
compilation regressions on the non-CoW code path.

Note: only compile checks are added, not test runs, because the
standard Hyperlight test guests require CoW paging which is disabled
under nanvix-unstable.

Changes:
- Justfile check: verify nanvix-unstable and nanvix-unstable+executable_heap
  compile on the host
- Justfile check-i686: verify hyperlight-common builds for i686 with
  nanvix-unstable enabled

Signed-off-by: danbugs <danilochiarlone@gmail.com>
@danbugs danbugs added kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. area/infrastructure Concerns infrastructure rather than core functionality labels Mar 9, 2026
@danbugs danbugs enabled auto-merge (squash) March 9, 2026 22:58
@jsturtevant
Copy link
Contributor

should we update clippy-exhaustive as well?

@danbugs danbugs disabled auto-merge March 9, 2026 23:10
@danbugs
Copy link
Contributor Author

danbugs commented Mar 9, 2026

should we update clippy-exhaustive as well?

clippy-exhaustive already tests w/ nanvix-unstable. clippy-exhaustive auto-discovers features to test w/ using cargo metadata. Verified it does pick it up locally rn:

❯ cargo metadata --format-version 1 --no-deps | jq -r '.packages[] | select(.name == "hyperlight-host") | .features | keys[]'
build-metadata
crashdump
default
executable_heap
function_call_metrics
fuzzing
gdb
kvm
mem_profile
mshv3
nanvix-unstable
print_debug
trace_guest

@danbugs danbugs enabled auto-merge (squash) March 9, 2026 23:19
@danbugs danbugs merged commit f392e25 into hyperlight-dev:main Mar 9, 2026
57 of 58 checks passed
@danbugs danbugs deleted the nanvix/ci-nanvix-unstable branch March 10, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infrastructure Concerns infrastructure rather than core functionality kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants