ci: add nanvix-unstable compile checks to CI and Justfile#1294
Merged
danbugs merged 1 commit intohyperlight-dev:mainfrom Mar 9, 2026
Merged
ci: add nanvix-unstable compile checks to CI and Justfile#1294danbugs merged 1 commit intohyperlight-dev:mainfrom
danbugs merged 1 commit intohyperlight-dev:mainfrom
Conversation
Add CI coverage for the nanvix-unstable feature flag to catch compilation regressions on the non-CoW code path. Note: only compile checks are added, not test runs, because the standard Hyperlight test guests require CoW paging which is disabled under nanvix-unstable. Changes: - Justfile check: verify nanvix-unstable and nanvix-unstable+executable_heap compile on the host - Justfile check-i686: verify hyperlight-common builds for i686 with nanvix-unstable enabled Signed-off-by: danbugs <danilochiarlone@gmail.com>
ludfjig
approved these changes
Mar 9, 2026
Contributor
|
should we update |
Contributor
Author
clippy-exhaustive already tests w/ nanvix-unstable. clippy-exhaustive auto-discovers features to test w/ using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds compile-time CI coverage for the
nanvix-unstablefeature flag introduced in #1291 to catch regressions on the non-CoW code path.Only compile checks are added — not test runs — because the standard Hyperlight test guests require CoW paging, which is disabled under
nanvix-unstable.Changes
Justfilecheck: verifynanvix-unstableandnanvix-unstable,executable_heapcompile on the hostJustfilecheck-i686: verifyhyperlight-commonbuilds for i686 withnanvix-unstableenabledThe
checkrecipe is already invoked by bothtest-like-ciandcode-checks-like-ci, so these checks run automatically in CI without needing a new workflow step.