Remove disallowed-macros lint#1397
Merged
simongdavies merged 1 commit intohyperlight-dev:mainfrom Apr 22, 2026
Merged
Conversation
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset and
syntactically
as code owners
ludfjig
approved these changes
Apr 21, 2026
Member
|
I think I agree that the lint was probably causing more trouble than it is worth, although it is kind of sad to lose a static analysis for this. It's a shame clippy doesn't have a more specific lint that would be easier to ensure was not false-positive on obvious cases like const code. |
andreiltd
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
disallowed-macroslint to detect the use ofassert!flags up the use ofdebug-assert!, use of assert in const expressions etc. This leads to more and more annotations in code to allow the valid use of asserts, rather than continually expand this this PR removes the lint in favour of detecting use of assert in release code via PR reviews