Skip to content

Crashdump on demand #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

Crashdump on demand #972

merged 2 commits into from
Oct 23, 2025

Conversation

@simongdavies
Copy link
Contributor

@simongdavies simongdavies commented Oct 23, 2025

This PR adds a function to the crashdump feature to allow a crashdump to be produced by calling a function on a sandbox.

This can be useful when debugging a process using gdb.

The updated doc has details on how to use this function

@simongdavies simongdavies added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Oct 23, 2025
@simongdavies
Adds a function to create a core dump on demand
6ee6dc7 
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
dblnz
dblnz previously approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@dblnz dblnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I don't think there is any security issue with allowing to generate a crashdump of a sandbox from the host, because if the host is compromised, then the access to guest memory is already a given, right?

ludfjig
ludfjig previously approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to have a test that exercises it so we don't break it in the future

@simongdavies
Add gdb script and update docs
cba2dcb 
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
@simongdavies simongdavies merged commit 3063e4a into hyperlight-dev:main Oct 23, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dblnz dblnz dblnz approved these changes

@ludfjig ludfjig ludfjig left review comments

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes is a code owner

Assignees

No one assigned

Labels

kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simongdavies @ludfjig @dblnz