Remove mshv2 feature #973
Merged
Remove mshv2 feature #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblnz
requested review from
danbugs,
devigned,
ludfjig,
marosset and
syntactically
as code owners
dblnz
added
the
kind/dependencies
ludfjig
approved these changes
Oct 23, 2025
ludfjig
previously approved these changes
Oct 23, 2025
Contributor
ludfjig
left a comment
ludfjig
left a comment
There was a problem hiding this comment.
LGTM. If you are able to follow up with similar PR in other hl-repos that would be great too
ludfjig
reviewed
Oct 23, 2025
dblnz
force-pushed
the
remove-mshv2
branch
2 times, most recently
from
93ac23a to
3bbd8b4
Compare
ludfjig
previously approved these changes
Oct 24, 2025
Contributor
ludfjig
left a comment
ludfjig
left a comment
There was a problem hiding this comment.
some nits otherwise looks good!
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the deprecated mshv2 feature, which is no longer in use. The changes systematically replace all references to mshv2 with mshv3 throughout the codebase, update build configurations, CI workflows, and remove now-unused code paths.
Key changes include:
- Replacing
mshvandmshv2feature flags withmshv3throughout the Rust codebase - Removing
mshv2-specific dependencies and conditional compilation blocks - Updating CI workflows and build scripts to remove
mshv2references - Simplifying feature flag logic in build configurations
Reviewed Changes
Copilot reviewed 20 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/hyperlight_host/Cargo.toml | Removed mshv2 package dependencies and feature flag definitions |
| src/hyperlight_host/build.rs | Updated build configuration to remove mshv2 feature alias and simplified mshv3 configuration |
| src/hyperlight_host/src/sandbox/hypervisor.rs | Updated hypervisor feature flags from mshv to mshv3, updated error message |
| src/hyperlight_host/src/sandbox/mod.rs | Updated test configuration to use mshv3 instead of mshv |
| src/hyperlight_host/src/sandbox/uninitialized_evolve.rs | Changed hypervisor setup conditional compilation from mshv to mshv3 |
| src/hyperlight_host/src/mem/memory_region.rs | Removed mshv2 extern declarations and conditional compilation blocks, cleaned up memory region implementation |
| src/hyperlight_host/src/hypervisor/regs/*.rs | Removed mshv2 extern declarations and updated feature flags to mshv3 across register implementations |
| src/hyperlight_host/src/hypervisor/mod.rs | Updated feature flags from mshv to mshv3 for Linux-specific code |
| src/hyperlight_host/src/hypervisor/hyperv_linux.rs | Removed mshv2 extern declarations and conditional compilation for VM creation and VCPU run |
| src/hyperlight_host/src/hypervisor/gdb/*.rs | Updated GDB debugging support to use mshv3 instead of mshv |
| src/hyperlight_host/src/error.rs | Removed mshv2 extern declaration and updated error handling to mshv3 |
| src/hyperlight_host/examples/guest-debugging/main.rs | Removed mshv2 feature flag handling from test configuration |
| Justfile | Updated all test and CI commands to remove mshv/mshv2 references, keeping only mshv3 and kvm |
| .github/workflows/*.yml | Updated CI workflows to remove mshv and mshv2 from test matrices and command invocations |
ludfjig
previously approved these changes
Oct 27, 2025
Contributor
ludfjig
left a comment
ludfjig
left a comment
There was a problem hiding this comment.
lgtm except that nit about custom logic
jsturtevant
previously approved these changes
Oct 27, 2025
simongdavies
previously approved these changes
Oct 27, 2025
Contributor
simongdavies
left a comment
simongdavies
left a comment
There was a problem hiding this comment.
a couple of nits otherwise LGTM
- This removes CI builds and tests for mshv2 feature - Removes mshv2 special handling of VMs Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
jsturtevant
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #648 by removing support for
mshv2which is no longer in use.