fix(scopes): use account:email scope over transition:email#285
Merged
jaredpereira merged 3 commits intohyperlink-academy:mainfrom Apr 17, 2026
Merged
Conversation
|
@hbjydev is attempting to deploy a commit to the Hyperlink Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hey! Thanks for doing this! I think we'll also need to add the scope to our top level oauth config (https://github.com/hyperlink-academy/leaflet/blob/main/app/api/oauth/%5Broute%5D/oauth-metadata.ts), and should leave transition:email in there as well for now, so as to not break existing sessions. That should be it though! |
Contributor
Author
|
@jaredpereira Done! :) |
Contributor
Author
|
Any chance of getting this looked at again today? :) I'm very much missing my ability to write on Leaflet atm lol |
hbjydev
force-pushed
the
fix/non-transitional-scopes
branch
2 times, most recently
from
95961f2 to
02e578e
Compare
Contributor
|
Tested locally and works great, thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the
transition:emailscope toaccount:email?action=read, dropping the transitional permission scope.This should fix issues like #272 for Tranquil PDS users, but also moves email address access to atproto's more fleshed out OAuth permissions system.