-
Notifications
You must be signed in to change notification settings - Fork 0
feat: mysql integration ci #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # ADR: MySQL integration coverage in CI | ||
|
|
||
| ## Status | ||
| Accepted on 2026-03-29. | ||
|
|
||
| ## Context | ||
| The repository already contains MySQL-backed integration coverage in `pkg/rain/mysql_integration_test.go`, and CI already runs separate SQLite and Postgres integration jobs. | ||
|
|
||
| That leaves one gap in cross-dialect runtime verification: MySQL behavior is exercised locally when contributors provide a DSN, but it is not enforced as a distinct signal in GitHub Actions. | ||
|
|
||
| The workflow already uses separate jobs per backend, so adding MySQL should preserve that structure rather than introducing a larger matrix refactor. | ||
|
|
||
| ## Decision | ||
| Add a dedicated `mysql-integration` job to the existing GitHub Actions workflow. | ||
|
|
||
| The new job: | ||
|
|
||
| - uses `ubuntu-latest` | ||
| - provisions a `mysql:8.4` service container | ||
| - creates a fixed `rain_test` database with a `rain` user | ||
| - passes `RAIN_MYSQL_DSN` to the test process | ||
| - runs `go test -race ./pkg/rain -run '^TestMySQLIntegration'` | ||
|
|
||
| Keep the existing SQLite and Postgres jobs unchanged. | ||
|
|
||
| ## Consequences | ||
| ### Positive | ||
| - CI now exposes MySQL runtime compatibility as an independent signal. | ||
| - Backend-specific failures remain isolated because each database keeps its own job. | ||
| - The workflow change is incremental and consistent with the current CI layout. | ||
|
|
||
| ### Negative | ||
| - CI runtime increases because another service-backed job must start and execute. | ||
| - The workflow now contains some duplicated setup across database jobs. | ||
|
|
||
| ## Testing approach | ||
| - Keep running the existing local validation flow: | ||
| - `make fmt` | ||
| - `make lint` | ||
| - `make test` | ||
| - In GitHub Actions, run `go test -race ./pkg/rain -run '^TestMySQLIntegration'` in the dedicated MySQL job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.