release/v21.03 - perf(compression): Use gzip with BestSpeed in export and backup (#7643)#7683
Merged
jarifibrahim merged 1 commit intorelease/v21.03from Apr 5, 2021
Merged
Conversation
The export and backup code were using BestCompression and Default gzip compression levels respectively. We see a 4x speed improvement when switching from BestCompression to BestSpeed compression level. (cherry picked from commit 5676462)
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
approved these changes
Apr 5, 2021
Contributor
NamanJain8
left a comment
NamanJain8
left a comment
There was a problem hiding this comment.
We will be using snappy instead of gzip in backup. Anyways, it should be fine to make these incremental improvements in performance, in case the snappy one doesn't make it into release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The export and backup code were using BestCompression and Default
gzip compression levels respectively. We see a 4x speed improvement when
switching from BestCompression to BestSpeed compression level.
(cherry picked from commit 5676462)
This change is