This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Remove extraneous types in graphql schemas#251
Merged
mattjohnsonpint merged 3 commits intomainfrom Jun 24, 2024
Merged
Conversation
HYP-1388 Runtime generates extraneous types in the GraphQL schema
Consider the example project at https://github.com/hypermodeAI/functions-as/tree/main/examples/http The generated GraphQL schema from the Runtime is: type Query {
createGithubIssue(owner: String!, repo: String!, title: String!, body: String!): Issue!
getExampleHtml: String!
getRandomImage(width: Int!, height: Int!): Image!
getRandomQuote: Quote!
}
type Header {
name: String!
values: [String!]!
}
type Headers {
data: [StringHeaderPair!]!
}
type Image {
contentType: String!
data: String!
}
type Issue {
title: String!
body: String!
url: String
}
type Quote {
quote: String!
author: String!
}
type Request {
url: String!
method: String!
headers: Headers!
body: String!
}
type Response {
status: Int!
statusText: String!
headers: Headers!
body: String!
}
type StringHeaderPair {
key: String!
value: Header!
}It should be: type Query {
createGithubIssue(owner: String!, repo: String!, title: String!, body: String!): Issue!
getExampleHtml: String!
getRandomImage(width: Int!, height: Int!): Image!
getRandomQuote: Quote!
}
type Image {
contentType: String!
data: String!
}
type Issue {
title: String!
body: String!
url: String
}
type Quote {
quote: String!
author: String!
}The extraneous types do indeed need to be extracted from the wasm and included in the metadata, so that the host functions that use them can operate correctly. However, since they aren't used in any types that are inputs or outputs of the query functions, then they shouldn't be be projected to GraphQL. This could be nuanced. For example, if one actually returned the |
jairad26
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #236, which was reverted in #241
Fixes HYP-1388