Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Use default parameter value in metadata if it exists#286

Merged
mattjohnsonpint merged 17 commits intomainfrom
jairus/hyp-1730-supply-default-values-for-optional-parameters-in-the-graphql
Jul 23, 2024
Merged

Use default parameter value in metadata if it exists#286
mattjohnsonpint merged 17 commits intomainfrom
jairus/hyp-1730-supply-default-values-for-optional-parameters-in-the-graphql

Conversation

@JairusSW
Copy link
Contributor

No description provided.

@JairusSW JairusSW requested a review from a team July 18, 2024 23:07
@linear
Copy link

linear bot commented Jul 18, 2024

HYP-1730 Supply default values for optional parameters in the GraphQL schema

See
https://hypermode.slack.com/archives/C06NBJD4JH3/p1721268174520529

In short, given AssemblyScript such as:

add(x: i32 = 1, y: i32 = 2): i32 { ... }

The corresponding GraphQL is currently:

add(x: Int, y: Int): Int!

whereas it should be:

add(x: Int! = 1, y: Int! = 2): Int!

@JairusSW JairusSW enabled auto-merge (squash) July 19, 2024 22:10
@mattjohnsonpint mattjohnsonpint disabled auto-merge July 23, 2024 16:23
@mattjohnsonpint mattjohnsonpint changed the title clean up Use default parameter value in metadata if it exists Jul 23, 2024
@mattjohnsonpint mattjohnsonpint merged commit 668c14e into main Jul 23, 2024
@mattjohnsonpint mattjohnsonpint deleted the jairus/hyp-1730-supply-default-values-for-optional-parameters-in-the-graphql branch July 23, 2024 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants