This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Fix GraphQL schema generation for Go functions#360
Merged
mattjohnsonpint merged 4 commits intomainfrom Sep 13, 2024
Merged
Conversation
HYP-2148 Add tests for GraphQL schema generation based on Go
We currently have tests for AssemblyScript but not Go, for the schema generation. I've seen a few glitches, so we should update the tests and fix the glitches. |
jairad26
approved these changes
Sep 13, 2024
mattjohnsonpint
deleted the
mjp/hyp-2148-add-tests-for-graphql-schema-generation-based-on-go
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had schema generation tests for AssemblyScript-based functions but not Go-based functions.
On adding the tests, I found and fixed two issues:
There's also some mismatch between what Go and AssemblyScript can support. We can solve that in the future. See HYP-2147 for more details.