This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Fix panic from Go maps with primitive types#370
Merged
mattjohnsonpint merged 3 commits intomainfrom Sep 18, 2024
Merged
Conversation
HYP-2171 Maps of primitive types are failing when built from the Go SDK
ex: This is due to some optimizations in the Go languages support, for passing slices of primitives, which weren't accounted for in the maps handler. |
jairad26
approved these changes
Sep 18, 2024
mattjohnsonpint
deleted the
mjp/hyp-2171-maps-of-primitive-types-are-failing-when-built-from-the-go
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a plugin compiled from the Go SDK used a map with a primitive type as it's value or key, a panic occurred in the runtime when the plugin was loaded.
This was due to the
mapHandlerpresuming that the keys and values could be written using asliceHandler. In the case of primitives, they're written with aprimitiveSliceHandlerinstead.Fixed, and added tests.