Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Automatically generate and push release info to R2 bucket on every release#526

Merged
kevinmingtarja merged 19 commits intomainfrom
kevinm/hyp-2523-automatically-generate-and-push-release-info-to-r2-bucket-on
Nov 4, 2024
Merged

Automatically generate and push release info to R2 bucket on every release#526
kevinmingtarja merged 19 commits intomainfrom
kevinm/hyp-2523-automatically-generate-and-push-release-info-to-r2-bucket-on

Conversation

@kevinmingtarja
Copy link
Contributor

@kevinmingtarja kevinmingtarja commented Oct 30, 2024

Description

  • Made a new script (/tools/release-info) to generate modus-all.json, modus-preview.json, modus-preview-all.json, and modus-preview.json,
  • Copied most of the code from /cli/src/util/versioninfo.ts, most of which should be removed in remove all github api call references, add prerelease support to CLI #545
  • Created release-info, which is a standalone workflow that can be invoked both manually (workflow_dispatch) and from another workflow (workflow_call), which in our case is release-cli, release-runtime, release-sdk-as, and release-sdk-go,
  • This workflow simply compiles and runs the script, and pushes the four JSON files to our releases R2 bucket

Checklist

  • Code compiles correctly and linting passes locally
  • Entry added to the CHANGELOG.md file describing and linking to this PR

@kevinmingtarja kevinmingtarja marked this pull request as ready for review November 3, 2024 06:42
@kevinmingtarja kevinmingtarja requested a review from a team November 3, 2024 06:42
@kevinmingtarja kevinmingtarja enabled auto-merge (squash) November 3, 2024 06:42
@kevinmingtarja kevinmingtarja force-pushed the kevinm/hyp-2523-automatically-generate-and-push-release-info-to-r2-bucket-on branch from 2a74550 to 02d33b1 Compare November 3, 2024 07:01
Copy link
Contributor

@jairad26 jairad26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it makes it easier, we could merge the PR #545 into this branch and close it so that we dont need another pr to remove the old versioninfo code from this as well. also this would mean theres now 2 places to maintain versioninfo.ts? i think we should be able to reference the existing one?

@kevinmingtarja
Copy link
Contributor Author

if it makes it easier, we could merge the PR #545 into this branch and close it so that we dont need another pr to remove the old versioninfo code from this as well. also this would mean theres now 2 places to maintain versioninfo.ts? i think we should be able to reference the existing one?

i think the contents of the two would have little to no overlap right? the new one here would only have the github API related code, while in the other only the releases JSON related code.

@jairad26
Copy link
Contributor

jairad26 commented Nov 4, 2024

i think the contents of the two would have little to no overlap right? the new one here would only have the github API related code, while in the other only the releases JSON related code.

Ah I see yea you’re right

@kevinmingtarja kevinmingtarja merged commit f8657fb into main Nov 4, 2024
@kevinmingtarja kevinmingtarja deleted the kevinm/hyp-2523-automatically-generate-and-push-release-info-to-r2-bucket-on branch November 4, 2024 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants