This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Merged
Conversation
jairad26
approved these changes
Nov 26, 2024
This was referenced Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Modus Go SDK has two compilation steps. This used to be required, but it turns out we've already addressed the cause of that and just hadn't removed the extra compilation. This PR removes the first pass, so there's just a single compile. Thus, build times are reduced significantly.
The PR also adds some diagnostic output, which is visible if
MODUS_TRACE=trueis set.Checklist
CHANGELOG.mdfile describing and linking to this PR