Conversation
|
|
||
| const extensions = ['.m4a', '.mp3'] | ||
|
|
||
| module.exports = (libPath, send, done) => { |
There was a problem hiding this comment.
maybe i should replace send, done with a simple callback so this file isn't so tightly coupled with the model.
|
LGTM! |
|
|
|
@bcomnes I'm only using about 10 files to test now, guessing streaming every metadata update to state is too much. |
|
I'm also running into a really weird bug where one file in particular causes electron to completely freeze without any console error or anything. |
|
I imagine there are going to be worlds of edge cases to deal with in this problem. Wrap in a setTimeout? |
|
@bcomnes sounds good for now, I'll try that. |
|
@bcomnes I tried putting |
|
Another option is to try throttling the stream -- either that or batching metadata updates. |
|
I have to work all day :( |
|
I may have figured out what's causing a crash -- I think I bet choo chokes on diffing state because a giant image buffer has been shoved in there. |
|
Okay gotta go for real, I might get to this today or might not. Need to get ready for a visit from my mom tomorrow followed by road trip to Seattle on Friday and flight to Paris Saturday! Busy week! |
|
Np. Nice work |
fixes album art buffer issue
|
Fixed the buffer issue and tweaked a couple minor things. Haven't gotten to try batching or throttling to slow down state updates from the metadata stream yet. Going to merge this for now as it's a good stopping point. |
|
Read through the whole Choo README and started looking through your work. Looks great! Go nate go! |
2 participants
First pass at getting real metadata in there. It's scanning whatever directory is set in config every time a new window gets opened for now, but it's real data!
Next step is getting it to rescan when
state.config.musicchanges. Then maybe caching metadata more intelligently.