Skip to content

experimental alternate layout & style#159

Merged
bcomnes merged 12 commits intomasterfrom
layout-experiments
Apr 28, 2017
Merged

experimental alternate layout & style#159
bcomnes merged 12 commits intomasterfrom
layout-experiments

Conversation

@ungoldman
Copy link
Copy Markdown
Member

still very WIP. I think it's looking pretty good though

screen shot 2017-04-26 at 9 53 30 pm

@bcomnes
Copy link
Copy Markdown
Contributor

bcomnes commented Apr 27, 2017

Oh wow that looks great!

@bcomnes
Copy link
Copy Markdown
Contributor

bcomnes commented Apr 27, 2017

Want me to merge #154 so there is less worry of conflicts?

@bcomnes
Copy link
Copy Markdown
Contributor

bcomnes commented Apr 27, 2017

Heads up, the folder scanner function is kinda messed up.

@ungoldman
Copy link
Copy Markdown
Member Author

@bcomnes I'm just experimenting at this point, don't worry about conflicts. I know this will be way off from what you're doing with the footer stuff right now.

Pretty happy with how this is turning out:

screen shot 2017-04-26 at 10 29 21 pm

Mini-player:

screen shot 2017-04-26 at 10 29 26 pm

I made it frameless!

@ungoldman
Copy link
Copy Markdown
Member Author

screen shot 2017-04-26 at 11 40 59 pm

Here's where I ended up ^

Done for tonight. woo

@bcomnes
Copy link
Copy Markdown
Contributor

bcomnes commented Apr 27, 2017

Looks really good. Thank you Nate :)

@bcomnes
Copy link
Copy Markdown
Contributor

bcomnes commented Apr 27, 2017

Merge?

@ungoldman
Copy link
Copy Markdown
Member Author

@bcomnes what about what you're doing with the footer stuff? wouldn't this conflict?

also wanted to rename footer to something more appropriate... maybe even rename player window to main, call footer player, and call the table and search components playlist

@bcomnes
Copy link
Copy Markdown
Contributor

bcomnes commented Apr 27, 2017

I'll reconcile the two tonight, and then we can rename every thing in one go.

@obensource
Copy link
Copy Markdown

@ungoldman looks super nice! Rad!

@bcomnes bcomnes mentioned this pull request Apr 28, 2017
@bcomnes
Copy link
Copy Markdown
Contributor

bcomnes commented Apr 28, 2017

Merged with the playback cluster component work. I'll link the two up later but this is good to merge once tests pass.

@bcomnes bcomnes removed the wip label Apr 28, 2017
@bcomnes bcomnes merged commit ad63a5a into master Apr 28, 2017
@bcomnes bcomnes deleted the layout-experiments branch April 28, 2017 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants