Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165
Closes #164
This makes the table a caching component, and also changes the data model quite a bit to use a object for all known tracks, and an array of keys, with the idea we could reduce data duplication around parts of the app, and also prepare for using a database to look up detailed track info.
This makes hyperamp work fairly well for about 2000 tracks, and we get 60 fps for simple position updates and track changes.
There are also some stateful edge cases when searching and clearing search with the currentIndex and the search param.
Album pics is busted again but should be easily fixable (it was already busted to some degree #120). I still think it might be interesting to do a picture server, so we don't have to put base64 encoded images into the dom #119).
Overall, good to go I would say!