Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes whitespace dom flapping. It looks like having the scroll bars intersect the scroll bar causes repaint on the scroll bar. One fix would be to not have these intersect on an x-y perpendicular axis (e.g. put the sliders parallel below or above the table) but its probably not that big of a deal.
I kind of want to go back to that arrangement anyway since horizontal space is super valuable and we eat up a lot with the player controls.
The main issue I think this solves is that it re-adds https://developer.mozilla.org/en-US/docs/Web/CSS/will-change which prevents painting on scrolling.
Closes #173