Conversation
We need to get yo-yoify into the build process before we release.
ungoldman
reviewed
Oct 28, 2017
Member
ungoldman
left a comment
There was a problem hiding this comment.
In the past I've done the following to avoid maintaining two nearly identical index.html files:
<script>
if (process.env.NODE_ENV === 'development') {
let bundle = document.createElement('script')
bundle.src = 'http://localhost:8283/bundle.js'
document.body.appendChild(bundle)
} else {
require('../bundle/bundle.js')
}
</script>Otherwise LGTM
Contributor
Author
|
We should do that. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to get yo-yoify into the build process before we release. @blahah released a nice transform that makes this work nicely in electron by prefixing require calls to built in to be
window.requireso that electron and other built in node calls still 'just work'.npm start: runs hyperamp in dev mode. Uses buds for building a bundle without making a mess on disk.npm run build: builds hyperamp without any additional optimizations. Does not create DMGnpm run prod: builds hyperamp with a few optimizations and creates a DMG.Closes #174