Conversation
Contributor
|
👍 |
Member
Author
|
Spent a lot of time trying to find a way around the electron / sheet-router reload bug. |
Member
Author
|
Did choo-location-electron circumvent that issue? You think it would work if we updated it to work with choo v4? |
Contributor
|
Pretty annoying when working on preferences I imagine. |
Member
Author
|
I gotta sign off for now, curious to see how we can get around it. Yeah, super annoying. |
Contributor
|
choo-location-electron did not have a reload after navigation issue in electron. |
Contributor
|
Ok I want dis. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changed a couple function signatures to have named options so that things are more optional/obvious. Added an optional
children-style parameter to button to allow for text (or anything else).