Skip to content

Keep selfloops in LaplacianPositionalEncodingEnricher#125

Merged
tizianocitro merged 1 commit intomainfrom
fix/keep-selfloops-in-lpe
Apr 1, 2026
Merged

Keep selfloops in LaplacianPositionalEncodingEnricher#125
tizianocitro merged 1 commit intomainfrom
fix/keep-selfloops-in-lpe

Conversation

@tizianocitro
Copy link
Copy Markdown
Contributor

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The LaplacianPositionalEncodingEnricher removed selfloops when calling reduce_to_edge_index_on_clique_expansion causing issues as this was changing the underlying hypergraph. This is something that should not happen when enriching node features. As a user, I wouldn't expect the hypergraph to change during this process.

Checklist

  • Does your submission pass all tests? (use make test)
  • Have you written tests to cover all your changes? If not, provide a reason.
  • Have you lint your code locally before submission? (use make lint)
  • Have you type checked your code locally before submission? (use make typecheck)
  • Have you added an explanation of what your changes are and why you'd like us to include them?

@tizianocitro tizianocitro merged commit faa554f into main Apr 1, 2026
18 checks passed
@tizianocitro tizianocitro deleted the fix/keep-selfloops-in-lpe branch April 1, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading dataset with node enricher

2 participants