Skip to content

feat: update privy logins #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luu-alex merged 1 commit into from
Apr 14, 2026
Merged

feat: update privy logins #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/config/privy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { PrivyClientConfig } from "@privy-io/react-auth";
import { arbitrum, arbitrumSepolia } from "wagmi/chains";

export const privyConfig: PrivyClientConfig = {
loginMethods: ["google", "wallet"],
loginMethods: ["google", "email", "twitter"],
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The wallet login method has been removed, preventing users from connecting external wallets (e.g., MetaMask, Phantom) directly through the Privy modal.

If this change was not intended to be restrictive, consider keeping wallet in the list of supported methods to maintain support for browser-based wallets.

Suggested change
loginMethods: ["google", "email", "twitter"],
loginMethods: ["google", "wallet", "email", "twitter"],

embeddedWallets: {
ethereum: {
createOnLogin: "users-without-wallets",
Expand Down
4 changes: 4 additions & 0 deletions src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,10 @@
}

@layer components {
#privy-dialog input#email-input ~ button {
display: none;
}
Comment on lines +394 to +396
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Hiding the button following the email input in the Privy dialog will likely break the email login flow, as users will have no visible way to submit their email address.

Overriding third-party component styles with display: none on functional elements is risky and can lead to a broken user experience and accessibility issues. If the goal was to hide a specific secondary button (like a 'Resend' button), this selector is likely too broad as it targets all subsequent sibling buttons.


.active\:scale-98:active {
transform: scale(0.98);
}
Expand Down
Loading