Skip to content

Feature clean argument keys #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vadymmarkov merged 2 commits into from
Nov 23, 2015
Merged

Feature clean argument keys #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fe541a
Remove delimiter from argument keys
Nov 22, 2015
7e4c0b3
Fix test
Nov 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Pod/Tests/TestCompass.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class TestCompass: XCTestCase {
let url = NSURL(string: "compassTests://profile:testUser")!
Compass.parse(url) { route, arguments in
XCTAssertEqual("profile:{user}", route)
XCTAssertEqual(arguments["{user}"], "testUser")
XCTAssertEqual(arguments["user"], "testUser")
}
}

Expand Down
2 changes: 1 addition & 1 deletion Source/Compass.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public struct Compass {

if queryArguments.count == routeArguments.count {
for (index, key) in routeArguments.enumerate() {
arguments[key] = index <= queryArguments.count && "\(query):" != prefix
arguments[String(key.characters.dropFirst().dropLast())] = index <= queryArguments.count && "\(query):" != prefix
? queryArguments[index] : nil
}
completion(route: route, arguments: arguments)
Expand Down