docs(effects): re-land v1 SPEC rule + effect.ml comment (#207 follow-up, Refs #59)#209
Merged
Merged
Conversation
The #207 squash-merge landed only the code commit; the docs commit (235e161) never reached main, leaving SPEC.adoc §3.4 still showing the retired Exn[Error] and lib/effect.ml still claiming Throws[E] is 'not yet threaded' — both now stale/incorrect on main. Re-landing them: - SPEC.adoc §3.4: Exn[Error] → Throws[E]; new 'Effect inference (tracking-only v1)' subsection (catch-less try/? ⇒ Partial; declared rows enforced inferred⊆declared; undeclared permissive); 'Partial by Default' disambiguated from the Partial effect. - lib/effect.ml: corrected the doc-drift comment (#204 threads Throws[E] via name-mangling in Typecheck.lower_effect_expr). Pure docs/comment; gate unchanged. Refs #59 (closed — lineage only, do not reopen). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔍 Hypatia Security ScanFindings: 44 issues detected
View findings[
{
"reason": "Stray AI.a2ml in root -- use 0-AI-MANIFEST.a2ml only",
"type": "banned",
"file": "AI.a2ml",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Superseded by 0-AI-MANIFEST.a2ml",
"type": "banned",
"file": "AI.djot",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Issue in quality.yml",
"type": "missing_workflow",
"file": "quality.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in security-policy.yml",
"type": "missing_workflow",
"file": "security-policy.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/example/smoke_driver.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/cli.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/mod.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/compile.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/runner.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: #207's out-of-band squash-merge took only the code commit; the docs commit (
235e161) never reachedmain. Somainstill has:docs/specs/SPEC.adoc§3.4 showing the retiredExn[Error]and no v1 effect-inference rulelib/effect.mlstill claimingThrows[E]is "not yet threaded" (false since feat(effects): thread parametric Throws[E] type argument (Refs #59) #204)Both are stale/lying on
main. This re-lands exactly those doc fixes (no code change, gate unchanged).Out-of-scope residual (unchanged, surfaced not half-swept): SPEC §5.2/§6.5 effect-handler examples still use
Exn— deferred handler-design territory, a separate sweep.Refs #59 (closed — lineage only).
🤖 Generated with Claude Code