Skip to content

docs(effects): re-land v1 SPEC rule + effect.ml comment (#207 follow-up, Refs #59)#209

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/effects-v1-spec-59
May 18, 2026
Merged

docs(effects): re-land v1 SPEC rule + effect.ml comment (#207 follow-up, Refs #59)#209
hyperpolymath merged 1 commit into
mainfrom
docs/effects-v1-spec-59

Conversation

@hyperpolymath
Copy link
Copy Markdown
Owner

Why: #207's out-of-band squash-merge took only the code commit; the docs commit (235e161) never reached main. So main still has:

Both are stale/lying on main. This re-lands exactly those doc fixes (no code change, gate unchanged).

Out-of-scope residual (unchanged, surfaced not half-swept): SPEC §5.2/§6.5 effect-handler examples still use Exn — deferred handler-design territory, a separate sweep.

Refs #59 (closed — lineage only).

🤖 Generated with Claude Code

The #207 squash-merge landed only the code commit; the docs commit
(235e161) never reached main, leaving SPEC.adoc §3.4 still showing the
retired Exn[Error] and lib/effect.ml still claiming Throws[E] is 'not
yet threaded' — both now stale/incorrect on main. Re-landing them:

- SPEC.adoc §3.4: Exn[Error] → Throws[E]; new 'Effect inference
  (tracking-only v1)' subsection (catch-less try/? ⇒ Partial; declared
  rows enforced inferred⊆declared; undeclared permissive);
  'Partial by Default' disambiguated from the Partial effect.
- lib/effect.ml: corrected the doc-drift comment (#204 threads
  Throws[E] via name-mangling in Typecheck.lower_effect_expr).

Pure docs/comment; gate unchanged. Refs #59 (closed — lineage only,
do not reopen).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@hyperpolymath hyperpolymath merged commit 0a4692a into main May 18, 2026
11 of 12 checks passed
@hyperpolymath hyperpolymath deleted the docs/effects-v1-spec-59 branch May 18, 2026 09:37
@github-actions
Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 44 issues detected

Severity Count
🔴 Critical 12
🟠 High 21
🟡 Medium 11

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Stray AI.a2ml in root -- use 0-AI-MANIFEST.a2ml only",
    "type": "banned",
    "file": "AI.a2ml",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "high"
  },
  {
    "reason": "Superseded by 0-AI-MANIFEST.a2ml",
    "type": "banned",
    "file": "AI.djot",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "high"
  },
  {
    "reason": "Issue in quality.yml",
    "type": "missing_workflow",
    "file": "quality.yml",
    "action": "create",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in security-policy.yml",
    "type": "missing_workflow",
    "file": "security-policy.yml",
    "action": "create",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
    "type": "unpinned_action",
    "file": "governance.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/example/smoke_driver.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/cli.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/compile.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/runner.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant