feat(effect-sites): #234 S2a — shared call-site numbering (ADR-016)

[hyperpolymath]

#234 S2a — shared call-site numbering (ADR-016 foundation)

ADR-016's keying mechanism. ExprApp has no loc/id and ADR-016 rejects annotating the AST, so the effect side-table is keyed by a deterministic shared call-site numbering: lib/effect_sites.ml — a single, total, pure pre-order traversal assigning every ExprApp a 0-based ordinal. Typecheck (producer) and the WasmGC CPS detector (consumer) will both call this function on the same prog, so keys cannot drift — no AST shape change.

This slice is the keying primitive only. No typecheck/codegen change → pure, gate-neutral. (S2b: typecheck builds the table on top; S3: pipeline thread + codegen switch + user-Async e2e; S4: retire the hardcoded set.)

• API: fold_calls / count / to_list / iter.
• Ordering contract (documented; stable; do-not-change-without-amending-ADR-016): strict left-to-right pre-order, call node numbered before its callee/arg sub-exprs. Exhaustive over every expr/stmt/block/match/handler/unsafe/fn-body/top-level position.
• test/test_effect_sites.ml: 5 cases — count, contiguous pre-order ordinals, determinism+purity (across runs & re-parses), zero-calls, calls nested in arg/while/for/match/lambda/block positions.

dune test --force 287/287. Zero regression.

Refs #234. Not Closes — staged campaign; owner closes per ISSUE-CLOSURE.

🤖 Generated with Claude Code

[github-actions]

🔍 Hypatia Security Scan

Findings: 47 issues detected

Severity	Count
🔴 Critical	12
🟠 High	21
🟡 Medium	14

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "Stray AI.a2ml in root -- use 0-AI-MANIFEST.a2ml only",
    "type": "banned",
    "file": "AI.a2ml",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "high"
  },
  {
    "reason": "Superseded by 0-AI-MANIFEST.a2ml",
    "type": "banned",
    "file": "AI.djot",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "high"
  },
  {
    "reason": "Issue in quality.yml",
    "type": "missing_workflow",
    "file": "quality.yml",
    "action": "create",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in security-policy.yml",
    "type": "missing_workflow",
    "file": "security-policy.yml",
    "action": "create",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
    "type": "unpinned_action",
    "file": "governance.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Action actions/checkout@v4 needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action denoland/setup-deno@v2 needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/example/smoke_driver.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/cli.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence