ci: drop continue-on-error on test-run step (bisect_ppx)

[hyperpolymath]

Summary

The "Run tests with bisect_ppx instrumentation" step in .github/workflows/ci.yml carried continue-on-error: true. Result: test failures (including QTT typechecker test regressions) were being reported as CI passes.

What changes

Removes one line: continue-on-error: true from the test-run step at line 178.

What is NOT changed

Intentional soft-fail patterns preserved on non-test steps:

• Lint with odoc (line 105) — docs lint.
• Build bench targets + Run benches (lines 127, 131) — benchmarks.
• Generate HTML coverage report (line 183) — coverage tooling artefact (failure here shouldn't mask test results).

Pattern context

Same anti-pattern class as:

• echo-types' N5Falsifier xfail gate (resolved via echo-types#136).
• echidna's Tier-2/3 live-test soft-fail (resolved via echidna#118).

The principle: "CI green" must reliably mean "tests pass". Soft-failing test steps breaks that invariant.

Refs

Estate prover-CI hygiene audit, recorded at:
`standards/adoption-readiness-grades/AUDIT-FINDINGS-2026-05-28.adoc`.

Test plan

• CI runs on this PR (hard-fails on real test regressions instead of silently masking).

🤖 Generated with Claude Code

[github-actions]

🔍 Hypatia Security Scan

Findings: 82 issues detected

Severity	Count
🔴 Critical	4
🟠 High	11
🟡 Medium	67

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "Action actions/checkout@v6 needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action denoland/setup-deno@v2 needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in affine-vscode-publish.yml",
    "type": "unknown",
    "file": "affine-vscode-publish.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "unknown",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "unknown",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence