ci(hypatia): re-adopt canonical hypatia-scan.yml — SARIF code-scanning + report truth-fix (#35 items 1 & 3)#38
Merged
Conversation
…h-fix) Closes burble#35 items 1 (Hypatia SARIF -> code-scanning) and 3 (remove dead robot-repo-automaton Phase 3 reference). Item 2 (re-arm Elixir test gate) is independent + blocked and tracked separately. Adopts the canonical change authored at source in rsr-template-repo (PR #53), also propagated to v3-templater (#73) and reposystem (#49), so burble does not drift from the template: - Dependency-free Node JSON->SARIF 2.1.0 converter; heterogeneous schema safe (optional line, empty/absolute file); empty/malformed input -> valid empty SARIF that clears stale alerts. - security-events: write; github/codeql-action/upload-sarif@v3.28.1 category 'hypatia' (coexists with codeql.yml); fork-PR guarded; deliberately not continue-on-error. - Explicit advisory gating policy documented in 'Check for critical issues'; dead robot-repo-automaton (Phase 3) report text removed. burble BEAM pins (Elixir 1.19.4 / OTP 28.3) preserved unchanged. Refs #35 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
🔍 Hypatia Security ScanFindings: 18 issues detected
View findings[
{
"reason": "Action ocaml/setup-ocaml@v3 needs attention",
"type": "unpinned_action",
"file": "affinescript-canary.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "No permissions declaration -- add permissions: read-all",
"type": "missing_permissions",
"file": "elixir-ci.yml",
"action": "add_permissions",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "binary_to_term without :safe option -- deserialization attack (1 occurrences, CWE-502)",
"type": "elixir_send_unsanitised",
"file": "/home/runner/work/burble/burble/server/lib/burble/media/lmdb_playout.ex",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "SSL verify_none disables certificate validation -- MITM risk (1 occurrences, CWE-295)",
"type": "elixir_no_ssl_verify",
"file": "/home/runner/work/burble/burble/server/lib/burble/bridges/mumble.ex",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "believe_me undermines formal verification (2 occurrences, CWE-704)",
"type": "believe_me",
"file": "/home/runner/work/burble/burble/src/interface/abi/Foreign.idr",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "Nickel file missing SPDX-License-Identifier header (1 occurrences, CWE-1104)",
"type": "ncl_missing_spdx",
"file": "/home/runner/work/burble/burble/configs/config.ncl",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "Lock.unwrap() without poison handling (14 occurrences, CWE-754)",
"type": "lock_unwrap",
"file": "/home/runner/work/burble/burble/tools/selur-compose/crates/selur-compose-driver/src/mock.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"line": 24,
"reason": "Secret found: Generic API key",
"type": "secret_detected",
"file": "/home/runner/work/burble/burble/.envrc",
"action": "revoke_rotate_and_purge",
"rule_module": "security_errors",
"severity": "critical"
},
{
"line": 39,
"reason": "Secret found: Password",
"type": "secret_detected",
"file": "/home/runner/work/burble/burble/server/lib/burble/safety/proven_bridge.ex",
"action": "revoke_rotate_and_purge",
"rule_module": "security_errors",
"severity": "critical"
},
{
"line": 53,
"reason": "Secret found: Password",
"type": "secret_detected",
"file": "/home/runner/work/burble/burble/server/lib/burble/bridges/sip.ex",
"action": "revoke_rotate_and_purge",
"rule_module": "security_errors",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes burble#35 items 1 & 3. Item 2 (re-arm Elixir test gate) is independent + blocked and tracked separately (sub-issue incoming).
Fixed at source (per maintainer decision): the canonical
hypatia-scan.ymllives in the template homes, so the change was authored in rsr-template-repo (PR #53) and propagated to v3-templater (#73) and reposystem (#49). This PR is burble re-adopting it — no drift, survives the next "adopt canonical" sweep.Item 1 — Hypatia SARIF → code scanning ✅
partialFingerprintsdedupe)security-events: write(documented; single-job so no narrower scope)github/codeql-action/upload-sarif@v3.28.1, categoryhypatia(coexists with CodeQL)Item 3 — dead autofix reference ✅
robot-repo-automaton (Phase 3)promise from the scan report# exit 1replaced by an explicit, documented advisory gating decisionValidation
YAML parses (verified); embedded converter passes
node --check; functional tests: absolute→repo-relative path, emptyfile→., severity mapping, sha256 fingerprints, malformed/empty input → valid empty SARIF. BEAM pins (1.19.4 / 28.3) unchanged (pin-guarded).Refs #35
🤖 Generated with Claude Code