fix(abi): correct EchidnaABI.Foreign module-decl + imports; delete orphan duplicate#153
Closed
hyperpolymath wants to merge 1 commit into
Closed
fix(abi): correct EchidnaABI.Foreign module-decl + imports; delete orphan duplicate#153hyperpolymath wants to merge 1 commit into
hyperpolymath wants to merge 1 commit into
Conversation
…phan duplicate The `EchidnaABI.Foreign` module declared itself as `module Echidna.ABI.Foreign` (with the dot) and imported `Echidna.ABI.Types` / `Echidna.ABI.Layout` — non- existent modules. The canonical namespace is `EchidnaABI.*` across the rest of `src/abi/`. This break unilaterally fails `idris2 --build echidnaabi.ipkg` and has kept the `Idris2 ABI Type-Check` CI workflow red on `main` since at least 2026-04-26 (5+ consecutive runs). Fix: - `src/abi/EchidnaABI/Foreign.idr` — module decl + 2 imports corrected (`Echidna.ABI.X` → `EchidnaABI.X`) - `src/abi/Foreign.idr` — orphan duplicate deleted. It carried the same typo'd content but was registered in the ipkg under no module name, so no build path could ever reach it. Deletion removes the which-file-is-canonical confusion. Unblocks PR #151 (TacticRecord) which was sitting blocked on this pre-existing failure. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
Closing — the Explore meander surfaced a broader picture in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EchidnaABI.Foreignwas self-declared asmodule Echidna.ABI.Foreign(with the dot) and imported the non-existentEchidna.ABI.Types/Echidna.ABI.Layout. The canonical namespace across the rest ofsrc/abi/isEchidnaABI.*.idris2 --build echidnaabi.ipkgand has kept theIdris2 ABI Type-CheckCI workflow red onmainsince at least 2026-04-26 (5+ consecutive runs).src/abi/Foreign.idr— an exact-content orphan duplicate that no module path could ever reach (not registered in the ipkg manifest, and module-decl didn't match its location either).Unblocks #151 (TacticRecord), which is sitting on this pre-existing failure.
Test plan
Idris2 ABI Type-Checkworkflow turns green on this PR (first green since Apr).idris2 --build echidnaabi.ipkgsucceeds locally on the prover-toolchain install.EchidnaABI/*.idrmodule referencesEchidna.ABI.*(scanned: only Foreign.idr was affected).🤖 Generated with Claude Code