fix(ci): bump secret-scanner SHA pin + scanner-allow pragma on test fixture#377
Merged
Merged
Conversation
…st fixture
Bumps the secret-scanner-reusable.yml pin from 3e4bd4c to 28fdf19
(standards#236: adds pragma + param-expansion + comment-line exemptions).
Adds `# scanner-allow: shell-secrets` pragma above the
`export ARANGODB_PASSWORD="testpassword"` line in integration/run-tests.sh.
The pragma makes the intent machine-readable; the param-expansion in
hooks/lib/cache.sh (CICD_CACHE_PASSWORD="${CICD_CACHE_PASSWORD:-}") now
passes automatically via the scanner's new RHS-detection logic.
Fixes: scan / shell-secrets persistent red on main.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🔍 Hypatia Security ScanFindings: 102 issues detected
View findings[
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in clusterfuzzlite.yml",
"type": "unknown",
"file": "clusterfuzzlite.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in clusterfuzzlite.yml",
"type": "unknown",
"file": "clusterfuzzlite.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
hyperpolymath
added a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secret-scanner-reusable.ymlpin from3e4bd4c→28fdf19(standards#236).# scanner-allow: shell-secretspragma aboveexport ARANGODB_PASSWORD="testpassword"inintegration/run-tests.sh.hooks/lib/cache.shline 22 (CICD_CACHE_PASSWORD="${CICD_CACHE_PASSWORD:-}") now passes automatically via the new param-expansion exemption — no code change needed there.What changed in standards#236
The
shell-secretsscanner job in the reusable gained four exemption layers:# scanner-allow: shell-secretsor# hypatia: allow security_errors/secret_detected) on same or preceding line..shell-secrets-ignorefile support (gitignore-style path globs).${VAR:-},${VAR:?},$VAR— not literals).#cannot hold real secrets).Test plan
🤖 Generated with Claude Code