fix(affine): migrate record literals to #{ } (affinescript#218)#91
Merged
Conversation
affinescript#218 (merged): bare { = block, records use #{ }. Migrated
all expression-position record literals in PlayerHP.affine including
nested inline records (hp:/iframes:/knockback:/player: value records,
the Player/UpdateResult constructions, and the if-expr velocity/kb
records). Blocks (fn bodies, if/else, { 1 }/{ 0 - 1 }) left unchanged.
Diff hand-verified; parses clean under the new compiler.
Refs hyperpolymath/affinescript#218
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔍 Hypatia Security ScanFindings: 55 issues detected
View findings[
{
"reason": "Issue in quality.yml",
"type": "missing_workflow",
"file": "quality.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in security-policy.yml",
"type": "missing_workflow",
"file": "security-policy.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "No permissions declaration -- add permissions: read-all",
"type": "missing_permissions",
"file": "serviceworker-check.yml",
"action": "add_permissions",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Python file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/idaptik/idaptik/dlc/idaptik-dlc-reversible/robot-repo-bot/_modules/robot_repo.py",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "Deno -A grants all permissions -- use specific --allow-* flags (3 occurrences, CWE-250)",
"type": "js_deno_all_perms",
"file": "/home/runner/work/idaptik/idaptik/run.js",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Nickel file missing SPDX-License-Identifier header (1 occurrences, CWE-1104)",
"type": "ncl_missing_spdx",
"file": "/home/runner/work/idaptik/idaptik/configs/config.ncl",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "getExn on external data -- use pattern matching (2 occurrences, CWE-754)",
"type": "getexn_on_external",
"file": "/home/runner/work/idaptik/idaptik/src/app/devices/VMBridge.res",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "JSON decode without validation (2 occurrences, CWE-20)",
"type": "json_decode_no_validation",
"file": "/home/runner/work/idaptik/idaptik/src/app/proven/SafeJson.res",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "JSON decode without validation (1 occurrences, CWE-20)",
"type": "json_decode_no_validation",
"file": "/home/runner/work/idaptik/idaptik/src/app/screens/BalanceAnalyserModel.res",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
affinescript#218 (merged) made bare
{a block; records use#{ }. Migrated all expression-position record literals insrc/app/combat/PlayerHP.affine(incl. nested inlinefield: #{…}records). Blocks left unchanged; diff hand-verified; parses clean under new compiler. Refs hyperpolymath/affinescript#218