[codex] fix TS allowlist path normalization#395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The current compiled checker walks files as
./repo-relative/path, while exemptions parsed from.claude/CLAUDE.mdare stored asrepo-relative/path. That meant exact-path exemptions such asrescript-ecosystem/packages/core/runtime-tools/bin/rrt.tsdid not match the generated.deno.jsruntime artifact even though the table row was parsed.The prime backtick hypothesis was not the full issue in the current source: the row parser already extracted code-span contents. The fix still normalizes parsed exemption cells by trimming and storing repo-relative paths, and it normalizes candidate paths before exact/glob matching.
Fix
./pathandpathcompare as the same repo-relative file..ts.bak/.tsx.bakas blocked TS artifacts so near-miss exemption paths do not slip through.scripts/check-ts-allowlist.tsand the compiledscripts/check-ts-allowlist.deno.jsartifact.Validation
scripts/tests/check-ts-allowlist-test.shpasses: 36 assertions across both checker targets.rescript-ecosystem/packages/core/runtime-tools/bin/rrt.tsand the approved CLAUDE.md table is clean after the fix.just check-ts-allowlist-driftis not clean locally because the current AffineScript compiler also fails to parse the unmodified HEAD source, and the recipe mishandles its temp variables after that failure. The committed.deno.jsartifact was therefore patched and validated directly.Consumer follow-up
New standards commit SHA to pin for this change:
681373b30b3615460ac3c802d6ba8db893b48d45.Consumers that pin
hyperpolymath/standards/.github/workflows/governance-reusable.yml@<sha>need a follow-up pin bump after this lands, includingdeveloper-ecosystemand the k9 repos. Note that currentmainhas drifted from861b5e911d9e5dcfb3c0ab3dd2a9a3c8fd0a1613; verify the reusable workflow shape when bumping consumers.