ci(pages): replace upload-pages-artifact composite with explicit SHA-pinned upload#38
Merged
Merged
Conversation
…pinned upload
`GitHub Pages` (casket-pages.yml) failed the org "all actions pinned to
a full-length commit SHA" ruleset with:
actions/upload-artifact@v4 is not allowed … must be pinned to a
full-length commit SHA
casket-pages.yml itself already pins every action. The violation is
*transitive*: `actions/upload-pages-artifact@v3` is a composite action
whose own action.yml does `uses: actions/upload-artifact@v4` (an
unpinned upstream moving tag) — and the ruleset evaluates nested
actions recursively, which we cannot pin from our side.
Fix: drop the composite and do exactly what it does, with a
SHA-pinned primitive — tar `_site` the way `actions/deploy-pages`
expects and upload it as the `github-pages` artifact via
`actions/upload-artifact@ea165f8d… # v4` (the same SHA already pinned
elsewhere in this repo). `configure-pages` / `deploy-pages` stay
(already pinned; they don't nest an unpinned upload-artifact).
No behaviour change to the published site; removes the only remaining
policy-blocked red. Pre-existing infra, unrelated to the #122/#30
source migration.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci(pages): replace upload-pages-artifact composite with explicit SHA-pinned upload
GitHub Pages(casket-pages.yml) failed the org "all actions pinned toa full-length commit SHA" ruleset with:
casket-pages.yml itself already pins every action. The violation is
transitive:
actions/upload-pages-artifact@v3is a composite actionwhose own action.yml does
uses: actions/upload-artifact@v4(anunpinned upstream moving tag) — and the ruleset evaluates nested
actions recursively, which we cannot pin from our side.
Fix: drop the composite and do exactly what it does, with a
SHA-pinned primitive — tar
_sitethe wayactions/deploy-pagesexpects and upload it as the
github-pagesartifact viaactions/upload-artifact@ea165f8d… # v4(the same SHA already pinnedelsewhere in this repo).
configure-pages/deploy-pagesstay(already pinned; they don't nest an unpinned upload-artifact).
No behaviour change to the published site; removes the only remaining
policy-blocked red. Pre-existing infra, unrelated to the #122/#30
source migration.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com