fix(cli): \start\ refuses explicitly instead of silent-exiting#71
Merged
Conversation
Closes #54. `verisimiser start` previously parsed the manifest, printed three status lines, then returned `Ok(())` because the interception daemon (V-L1-C1, #46) hasn't been built. That looks like a successful start, which is worse than not having the subcommand at all — anyone running `verisimiser start` would assume their database is being augmented when nothing is happening. Replace the print-and-exit with `anyhow::bail!` that: - still loads the manifest (so config errors surface) - names the tracking issue (#46 / V-L1-C1) in the error message - exits non-zero, so shell scripts and CI gates notice This is option (a) from the issue: refuse with a typed error. Once the interception daemon lands in V-L1-C1, the bail can be replaced with the actual daemon loop. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per V-L3-G3 option (a): refuse explicitly.
verisimiser startparsed the manifest, printed three status lines, then returnedOk(())because the interception daemon hasn't been built — looking like a successful start while doing nothing. Replace the print-and-exit withanyhow::bail!that names the tracking issue (#46 / V-L1-C1) and exits non-zero.Closes
Test plan
cargo clippy --all-targets -- -D warningscleancargo test --lib --binscleanverisimiser start --manifest some.tomlnow exits 1 with a message naming V-L1-C1: end-to-end SQLite Tier 1 — sqlite3_update_hook + sidecar provenance writer #46When V-L1-C1 lands, the
bail!gets replaced with the real daemon loop.