fix+feat: codebase review improvements — 9 bug fixes, expanded linter, LSP/DAP fixes#8
Merged
JoshuaJewell merged 2 commits intomainfrom Apr 9, 2026
Conversation
- Fix crate name mismatch: fmt/lint main.rs used vqlut_* instead of vcltotal_* - Fix linter false-positive: no longer flags already-uppercase keywords - Fix formatter word-boundary: SELECTED no longer matches SELECT prefix - Add VCL-total extension keywords to formatter (OFFSET, EFFECTS, PROOF, CONSUME) - Add missing Level 5 ResultTypeError to VclTotalError.res error codes - Deduplicate statementFieldRefs in Checker.idr (remove redundant where block) - Fix checkQuery returning Ok for parse errors (now returns Error) - Fix incomplete JSON escaping in reportToJson (handle \, \n, \r, \t) - Update tests to match corrected behavior (all 72 pass) https://claude.ai/code/session_019DLW587RVJf7K9jF91e8vK
- Linter: add SELECT * warning (Level 5 result typing), OFFSET without LIMIT detection, VCL-total extension keyword case checks (EFFECTS, PROOF, CONSUME, USAGE, OFFSET) - LSP: fix compilation errors (sync API, extract return type, mod lib warning), expand completions with all VCL-total keywords and safety level descriptions, remove unused params - DAP: return explicit error for missing/invalid query argument instead of silently defaulting to empty string - CI: GitLab cargo-build now uses --workspace --all-targets to catch binary compilation failures across all crates - Tests: 10 new tests for formatter extension keywords, SELECT * lint, OFFSET-without-LIMIT lint, extension keyword case checking (82 total) https://claude.ai/code/session_019DLW587RVJf7K9jF91e8vK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two commits resulting from a thorough codebase review, fixing 9 bugs and adding new features across the linter, LSP, DAP, and CI.
Commit 1:
fix: correct 9 bugs and issues across codebasevqlut_*→vcltotal_*)SELECTEDno longer matchesSELECTOFFSET,EFFECTS,PROOF,CONSUMEResultTypeErrorstatementFieldRefsOkfor parse errors — now correctly returnsErrorreportToJsonCommit 2:
feat: expand linter, fix LSP/DAP, strengthen CISELECT *warning,OFFSET-without-LIMITdetection, and extension keyword case checkscargo-buildjob now uses--workspace --all-targetsfor full coverageAll 82 tests pass. Full workspace builds clean.