Skip to content

Bug/alt 11011#36

Merged
Tsyklop merged 8 commits into
mainfrom
bug/ALT-11011
Apr 28, 2026
Merged

Bug/alt 11011#36
Tsyklop merged 8 commits into
mainfrom
bug/ALT-11011

Conversation

@Tsyklop
Copy link
Copy Markdown
Collaborator

@Tsyklop Tsyklop commented Apr 24, 2026

This PR addresses critical issues project opening (ALT-11011). modernizes the project opening logic to align with the latest IntelliJ Platform APIs.

🏗 Platform & API Updates

  • API Modernization: Refactored OpenProjectTaskCompat to use the latest lambda-based constructor for OpenProjectTask, removing deprecated property assignments.
  • Dependency Refresh: Updated gradle-261.properties to target the latest stable IDE versions (IU-2026.1.1, CL-2026.1.1, etc.).

Copy link
Copy Markdown
Contributor

@meanmail meanmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

The PR updates OpenProjectTaskCompat for the 261 platform branch and bumps IDE versions from EAP/RC to stable releases. The key behavioral changes are setting useDefaultProjectAsTemplate = false and runConversionBeforeOpen = false.

Comments

  1. useDefaultProjectAsTemplate and runConversionBeforeOpen changes — these appear to be the actual fix for ALT-11011. Worth noting: the 252/253 branches use the lambda builder and don't explicitly set these properties, so they get whatever the builder defaults to. If the builder defaults differ from false, the behavior may be inconsistent across platform versions. Please verify.

  2. beforeInit simplification — good cleanup, removing the redundant wrapper lambda.

  3. preparedToOpen cleanup — the null-check pattern is now cleaner and consistent with the intent.

  4. Positional constructor retained for 261 — the previous commit switched to the lambda builder (matching 252/253), but this commit reverts to the positional constructor. Is there a specific reason? The lambda builder is more maintainable (no need to specify every parameter).

  5. IDE version updates — moving from EAP snapshots to stable 2026.1.x releases is good.

@Tsyklop Tsyklop requested a review from meanmail April 28, 2026 06:38
@Tsyklop Tsyklop merged commit 42a46ba into main Apr 28, 2026
0 of 3 checks passed
@Tsyklop Tsyklop deleted the bug/ALT-11011 branch April 28, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants