Skip to content

Conversation

@Tim-Blokdijk
Copy link
Contributor

  • Removed the phrase "state machine" as it's not normaly used in Ruby or Rails. The reader might not be familiar with it.
  • save as the name of one of the triggers renamed to saved as it changes the @editing state and not doing any saving.
  • Shell commands are displayed in a consistent style.
  • Bit more text with context added in chapter 1.
  • Warped long paragraphs.
  • Fixed a few typos.
  • Extra whitespace removed.
  • Other things..

Current problems:
Chapter 7
"Notice that as you click each link the page reloads."
FIXME: The links created don't actually fully reload the page, it's showing the scoped ToDo model data of the previous request. Directly requesting the url works as expected. Replacing the anchor <A> elements with the NavLink component fixes this.

Chapter 8
At row 582
FIXME: The relationship between todo and @Todo isn't explained. The @Variable is a new feature.

Chapter 11
At row 840
FIXME: li.todo-item .toggle { -webkit-appearance: none; } in the css makes the checkboxes disapear?

… or Rails. The reader might not be familiar with it.

* `save` as the name of one of the triggers renamed to `saved` as it changes the `@editing` state and not doing any saving.
* Shell commands are displayed in a consistent style.
* Bit more text with context added in chapter 1.
* Warped long paragraphs.
* Fixed a few typos.
* Extra whitespace removed.
* Other things..

Current problems:
Chapter 7
"Notice that as you click each link the page reloads."
FIXME: The links created don't actually fully reload the page, it's showing the scoped ToDo model data of the previous request. Directly requesting the url works as expected. Replacing the anchor \<A\> elements with the NavLink component fixes this.

Chapter 8
At row 582
FIXME: The relationship between `todo` and `@Todo` isn't explained. The `@Variable` is a new feature.

Chapter 11
At row 840
FIXME: li.todo-item .toggle { -webkit-appearance: none; } in the css makes the checkboxes disapear?
@catmando
Copy link
Contributor

catmando commented Dec 7, 2018

Thanks a lot. I'll get this merged soon as possible.

@catmando catmando merged commit fa60930 into hyperstack-org:edge Dec 7, 2018
@catmando
Copy link
Contributor

catmando commented Dec 7, 2018

Thanks. I merged the changes. I was not able however to reproduce/understand the three "current problems"

Chapter 7. Works fine for me... page reloads as you click each link.
Chapter 8. Hmmm... it is explained when params are first introduced in chapter 4.

Params are declared using the param macro and are accessed via Ruby instance variables. Notice that the instance variable name is CamelCased so that it is easily distinguished from other instance variables.

Perhaps we should repeat this a couple of times to make in more obvious?
Chapter 11. Again not having any problem. I am only testing on Chrome. Are you on a different browser?

@Tim-Blokdijk
Copy link
Contributor Author

Firefox, did not test it with Chrome.
Would have to go trough the tutorial again to reproduce myself.

As for the params, I haven't made up my mind yet.

At https://hyperstack.org/edge/docs/tutorials/todo I see that the backslash at line end notation isn't supported. So it needs a few touch-ups. Maybe I can push something tonight but if not then it might take a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants