Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

Long standing bug where an empty attribute definition (the default) is assigned rather than leaving the field unset. This breaks presence detection downstream (i.e. attribute.hasAttributeDefinition())

Testing

Added unit and integration test.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner September 5, 2023 20:21
@aaron-steinfeld aaron-steinfeld changed the title fix: attribtue definition should be unset if default fix: attribute definition should be unset if default Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Test Results

103 tests  +1   103 ✔️ +1   12s ⏱️ -2s
  24 suites ±0       0 💤 ±0 
  24 files   ±0       0 ±0 

Results for commit 4f313ad. ± Comparison against base commit e9a2b88.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #173 (4f313ad) into main (e9a2b88) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #173      +/-   ##
============================================
+ Coverage     82.82%   82.84%   +0.01%     
- Complexity      281      282       +1     
============================================
  Files            33       33              
  Lines           949      950       +1     
  Branches         73       74       +1     
============================================
+ Hits            786      787       +1     
  Misses          111      111              
  Partials         52       52              
Flag Coverage Δ
integration 82.84% <100.00%> (+0.01%) ⬆️
unit 69.75% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ttribute/service/model/AttributeMetadataModel.java 83.33% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-steinfeld aaron-steinfeld merged commit 7bd72ca into main Sep 5, 2023
@aaron-steinfeld aaron-steinfeld deleted the fix-attribute-def-presence branch September 5, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants