fix: update attribute service version #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
requested review from
ankitchoudhary111,
skjindal93 and
surajpuvvada
surajpuvvada
previously approved these changes
Sep 10, 2022
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
=========================================
Coverage 74.10% 74.10%
Complexity 69 69
=========================================
Files 14 14
Lines 560 560
Branches 34 34
=========================================
Hits 415 415
Misses 128 128
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjindal93
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attribute Service hasn't been upgraded since
internalflag added in hypertrace/attribute-service#106 , so it's never been able to write it. Updating to fix.