Exposing a method to set request context in the mock config service#163
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
============================================
- Coverage 80.33% 80.24% -0.09%
Complexity 457 457
============================================
Files 54 54
Lines 2278 2283 +5
Branches 85 86 +1
============================================
+ Hits 1830 1832 +2
- Misses 398 401 +3
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| return this; | ||
| } | ||
|
|
||
| public MockGenericConfigService withRequestContext(RequestContext context) { |
Contributor
There was a problem hiding this comment.
So this was really a placeholder context to avoid having to set a context in a test client, but if you actually do care about a context, it would be better to send it the regular way (via client) rather than assigning it in the server. Could we explore that option instead (that might look like changing the test interceptor in this file to only set the context if unset, for example).
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Providing support to add headers to the request context in the mockconfigservice
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.