Skip to content

Remove exception logging from error log #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanket-mundra merged 2 commits into from
Jun 12, 2023
Merged

Remove exception logging from error log #167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9abf8b
Logging exception only in case of debug
sanket-mundra Jun 12, 2023
c5a2345
update
sanket-mundra Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ng-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ private boolean matches(String lhs, String rhs, RelationalOperator relationalOpe
try {
return Pattern.compile(rhs).matcher(lhs).find();
} catch (Exception e) {
log.error("Invalid regex: {} passed to match: {}", rhs, e);
log.error("Invalid regex: {} passed to match", rhs);
if (log.isDebugEnabled()) {
log.debug(
"Invalid regex passed to match. Hence returning false. lhs: {} and rhs: {}",
Expand Down