chore | delete configs permanently rather than soft deletes#178
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
============================================
- Coverage 79.93% 79.78% -0.16%
Complexity 478 478
============================================
Files 54 54
Lines 2382 2384 +2
Branches 104 103 -1
============================================
- Hits 1904 1902 -2
Misses 420 420
- Partials 58 62 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SrikarMannepalli
previously approved these changes
Oct 11, 2023
skjindal93
reviewed
Oct 11, 2023
skjindal93
reviewed
Oct 11, 2023
skjindal93
previously approved these changes
Oct 11, 2023
| } | ||
| } | ||
|
|
||
| private Datastore initDataStore(Config config) { |
Contributor
There was a problem hiding this comment.
nit - we can come back to this, but I believe latest doc store has a new interface here.
aaron-steinfeld
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.