Skip to content

Add not exists, not equals and not matches regex operator support for label application rules#196

Merged
sanket-mundra merged 1 commit into
mainfrom
sanket/addNotOperatorSupportForLabelRule
Jan 9, 2024
Merged

Add not exists, not equals and not matches regex operator support for label application rules#196
sanket-mundra merged 1 commit into
mainfrom
sanket/addNotOperatorSupportForLabelRule

Conversation

@sanket-mundra

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@sanket-mundra sanket-mundra requested a review from a team as a code owner January 9, 2024 13:38
@github-actions

github-actions Bot commented Jan 9, 2024

Copy link
Copy Markdown

Test Results

120 tests  +2   120 ✅ +2   57s ⏱️ -4s
 29 suites ±0     0 💤 ±0 
 29 files   ±0     0 ❌ ±0 

Results for commit 2a072d0. ± Comparison against base commit 95c6f4e.

@codecov

codecov Bot commented Jan 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95c6f4e) 79.92% compared to head (2a072d0) 79.92%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #196   +/-   ##
=========================================
  Coverage     79.92%   79.92%           
  Complexity      488      488           
=========================================
  Files            54       54           
  Lines          2416     2416           
  Branches        106      106           
=========================================
  Hits           1931     1931           
  Misses          425      425           
  Partials         60       60           
Flag Coverage Δ
integration 79.92% <ø> (ø)
unit 78.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanket-mundra sanket-mundra merged commit 3c6d8a3 into main Jan 9, 2024
@sanket-mundra sanket-mundra deleted the sanket/addNotOperatorSupportForLabelRule branch January 9, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants